[pull] master from facebook:master #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix Readme link to Testing section Fix Readme link to Testing section ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Fixed] - Fixed link to Testing in React Native Android ReadMe file Pull Request resolved: #31387 Test Plan: Change has been made to a Readme documentation, no changes in code Reviewed By: TheSavior Differential Revision: D28192184 Pulled By: PeteTheHeat fbshipit-source-id: 6d4503f68398accacead116b43981e03e4c1430a
Summary: NativeModules can read from, or write to, the bridge's bundleURL. To do so, they access the bundleURL property on the bridge directly. **Setter:** https://www.internalfb.com/code/fbsource/[2a74581dfff31febe6e91c5739294705f5244ecb]/xplat/js/react-native-github/React/CoreModules/RCTDevMenu.mm?lines=213-214 **Getter:** https://www.internalfb.com/code/fbsource/[2a74581dfff31febe6e91c5739294705f5244ecb]/xplat/js/react-native-github/React/CoreModules/RCTDevMenu.mm?lines=245%2C256 In bridgeless mode, the bridge is nil. So, this form of access will fail. After this stack lands, every NativeModule will be able to synthesize an RCTBundleManager, like so: ``` synthesize bundleManager = _bundleManager; ``` From then on, all NativeModules will use this bundleManager to access the bundle URL. This should ensure that NativeModules can read from/write to the bundleURL, **even in bridgeless mode**. Changelog: [iOS][Added] - Introduce RCTBundleManager for bundleURL access Reviewed By: PeteTheHeat Differential Revision: D28086318 fbshipit-source-id: 34c15bf05c144341aa912fad9aa25d6d3a364f9e
Summary: After this diff, every NativeModule that has `synthesize bundleManager = _bundleManager`, will get access to an RCTBundleManager, that it can use to read from/write to the bridge's bundle URL. Changelog: [iOS][Added] - Attach RCTBundleManager to NativeModules Reviewed By: PeteTheHeat Differential Revision: D28086319 fbshipit-source-id: 6e4cd815d300e9036957ec8c743e947d2cb3f365
Summary: See title. Changelog: [Internal] Reviewed By: PeteTheHeat Differential Revision: D28160096 fbshipit-source-id: c14e5a5bc9f226f1e2559b3a256edcf5379d3c2e
Summary: This diff gets rid of bridge usage in RCTDevMenu's _menuItemsToPresent method. Changelog: [Internal] Reviewed By: PeteTheHeat Differential Revision: D28164301 fbshipit-source-id: 6445c787519af887209ee312f1c2dbaef873e00d
Summary: See title. Changelog: [Internal] Reviewed By: PeteTheHeat Differential Revision: D28192004 fbshipit-source-id: fd916237030ad51c7687e8196d7e0b6d3b3c02b5
Summary: See title. Changelog: [Internal] Reviewed By: PeteTheHeat Differential Revision: D28192003 fbshipit-source-id: a1a21782b51f327b9b92c60c7e9bd7251fcdebf0
Summary: See title. Changelog: [Internal] Reviewed By: PeteTheHeat Differential Revision: D28192005 fbshipit-source-id: b61406bdd32cd7511d7f2abb7bead819894fce9a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )