Fixed Alert Screen #196
Closed
Fixed Alert Screen #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag-singhal
added
the
RNTester
chirag-singhal
requested review from
AnshG714,
YashKumarVerma,
anku255,
manyaagarwal and
sansyrox
anku255
reviewed
Aug 10, 2020
Member
anku255
left a comment
anku255
left a comment
There was a problem hiding this comment.
This will be fixed by #183
In fact, I had fixed it in the main Facebook repo facebook#29150 and it should be fixed automatically if we rebase with upstream.
And looks like you will need to make changes to RNTester/js/utils/RNTesterList.android.js file as well.
Author
|
@anku255 I tested and it was working fine but we can close this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog