Skip to content

Conversation

@leodotcloud
Copy link

No description provided.

@leodotcloud
Copy link
Author

Can you please review @eggman64, @Donnie, @christophstrasen?

@eggman64
Copy link
Member

eggman64 commented Jun 1, 2020

Hey @leodotcloud thanks for your contribution.

Currently we have pretty good code coverage and we would be grateful if you added a small test to the new function that you have contributed.

I suggest you take a peek at the pem Verify method in the docs here.

Additionally, we add comments with the zendesk url like

// OrganizationMembership represents a Zendesk association between an org and a user.

Apologies for the missing Contribution guidelines. Will soon take care of that.

@eggman64 eggman64 self-requested a review June 1, 2020 11:39
Copy link
Member

@eggman64 eggman64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test case as well.

Thank you!

"fmt"
"io/ioutil"
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description like so:

// CreateOrganizationMembership creates an organization membership.
//
// Zendesk Core API docs: https://developer.zendesk.com/rest_api/docs/core/organization_memberships#create-membership

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants