Skip to content

Fix #2343, support pre-commit #3253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix #2343, support pre-commit #3253

wants to merge 2 commits into from

Conversation

Freed-Wu
Copy link
Contributor

@Freed-Wu Freed-Wu commented Aug 17, 2025 •
edited
Loading

Test file:

test.lua:

---@param x integer
function f(x)
    x = "a"
end
---
repos:
  - repo: https://github.com/Freed-Wu/lua-language-server
    rev: 3.15.1
    hooks:
      - id: lua-language-server-check
Screenshot_20250822_164637

@Freed-Wu Freed-Wu marked this pull request as draft August 17, 2025 22:37
@Freed-Wu Freed-Wu force-pushed the pre-commit branch 2 times, most recently from a4ebc5c to 70aaa4d Compare August 20, 2025 15:42
@Freed-Wu Freed-Wu marked this pull request as ready for review August 20, 2025 15:51
@Freed-Wu Freed-Wu marked this pull request as draft August 20, 2025 17:28
@Freed-Wu
Improve lua-lanuageserver --check
9187442 
Original LuaLS#2775 only pass exe, which is arg[minIndex].
arg from minIndex + 1 to -1 are ignored.

For example, when arg from -3 to 2 is
/the/path/of/bootstrap -e XXX lua-language-server --check .
It will only pass
/the/path/of/bootstrap lua-language-server --check .
@Freed-Wu
Fix LuaLS#2343, support pre-commit
213cb58
@Freed-Wu Freed-Wu marked this pull request as ready for review August 22, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Freed-Wu