✨ feat(app): [Compatibility changes] add input normalization to language detection #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalize text input to improve detection accuracy, particularly for all-uppercase text. This prevents misdetection as Japanese by converting uppercase text to lowercase. This enhancement ensures more reliable language predictions.
Reordered imports for better readability and alignment with PEP 8. This change enhances maintainability by ensuring consistent import order, making the codebase easier to navigate and understand. 🛠️
Enhanced text normalization by removing newline characters and lowercasing uppercase text to improve prediction accuracy. Added warnings for deprecated parameters and improved configuration management using LangDetectConfig. These changes enhance text preprocessing and ensure better configuration management.
Removed the `test_newline` function from `tests/test_real_detection.py` as it was deemed unnecessary. This streamlines our test suite by eliminating redundant checks, ensuring more focused and efficient test execution.
sudoskys
changed the title
Improved `_normalize_text` to static method and refined logging messages for better clarity. This change enhances text processing by explicitly handling newline characters and long inputs, as well as aligning with issue #14. 🛠️ Refactoring ensures better code maintainability and readability.
Introduced `_preprocess_text` method to clean and validate text before detection. This ensures removal of newline characters and warns if text length exceeds 100 characters, enhancing prediction accuracy and preventing errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.