Added Behance, Google Drive & Friendi.ca buttons #652
Conversation
|
Gotta put a hold on buttons for a minute. |
|
Here is the first draft: main...button-db#diff-fdc3ead7ad583031fdd6763582319d4e9f5e022fdf4f8b2a76908013aa34ad9d System load and response time should be about the same (unless you had an external db...). If you are using Redis, the file will be cached. We need to carry over the button IDs for internal legacy systems. But now we can easily have button categories, proper spelling, and future proofing all in one file. |
|
Still not sure about the migration. We loose around 50 milliseconds to an uncached request to the database JSON compared to the database, in a worst case scenario with over 100 buttons. This file is requested on every links page load. I might have to scrap this feature... I may have to rewrite the updater to work with the existing database and just add new tables. |
|
@Realmlist Do you have any idea what to do for the X/Twitter button? |
|
Alright, I'm scrapping the JSON layout. I updated the database. Please make sure your commit is up-to-date with this new format. Each entry now includes an alt field where the display name for the button is defined. Also, please make sure the alt field in your previous commit matches the new format: https://github.com/LinkStackOrg/LinkStack/blob/main/database/seeders/ButtonSeeder.php#L877-L907 |
|
Changes are active in |
Added Behance button (Behance Icon #629)
Added Google Drive button (Google Drive icon #543)
Added Friendi.ca button (Add 'Friendi.ca' predefined site #284)
Adjusted Pronouns.Page button color according to their design guidelines