add .sub option for passing in your own sub db #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sub is fine, lgtm! |
|
will leave time for others to comment, have added you as collaborator also |
|
I think this is an excellent solution. It may not fix everything - a sublevel-based levelup instance might still throw errors on some of level-ttl's operations, I'm not sure. Ideally we'd have passing unit tests, and then we could add a unit test for sublevel support, but that's been easy enough to ignore so far... :-x +1 |
rvagg
added a commit
that referenced
this pull request
Dec 23, 2014
add .sub option for passing in your own sub db
|
published as 2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is intended to address #15
the idea is simply that you can pass your own levelup-ish instance in
I tested this with level-session and it fixes the issues with level-sublevel v6
another idea for the option name I had was
ttldbrather thansub. LMK if you like that more and I can update it