[main] Fixing active counts slow queries. (#5907) #5917
Conversation
* Fixing active counts slow queries. * Simplify back to str tuple * Batch site and community updates * Using update from temp table * Making aggs temp table use interval name. * Make dev setup use optimized postgres. * Addressing PR comments. * Use ref * Removing system custom info from customPostgresql.conf
dessalines
requested review from
phiresky,
dullbananas,
Nutomic and
SleeplessOne1917
as code owners
There was a problem hiding this comment.
This won't be run by an instance that already ran the post_like/comment_like variant of this migration. So the indexes would not be created for the new combined actions tables on that instance. You probably need to do all of these:
- keep this migration unchanged
- change the dates of the smoosh-tables-together migration and of other migrations that need to come after smoosh-tables-together
- add these indexes to the smoosh-tables-together migration if they aren't there already
Also there should be WHERE liked_at IS NOT NULL on these indexes. Parenthesis might be needed.
There was a problem hiding this comment.
Good call. I'll diff the migrations folders between main and release/v0.19, and make sure nothing is missing, and that all the dates in main all come after the v0.19 migrations
| active_counts(&mut context.pool(), ONE_DAY).await?; | ||
| all_active_counts(&mut context.pool(), ALL_ACTIVE_INTERVALS).await?; | ||
| update_local_user_count(&mut context.pool()).await?; |
There was a problem hiding this comment.
Added tests for all these new ones here.
There was a problem hiding this comment.
Good call. I'll diff the migrations folders between main and release/v0.19, and make sure nothing is missing, and that all the dates in main all come after the v0.19 migrations
Checked using git diff --diff-filter D --stat release/v0.19 migrations
|
I've now renamed all the
In the future, lets backdate any migrations necessary on |
There was a problem hiding this comment.
This migration was in release/v0.19 only, and it has been run on production servers. Copied it over.
There was a problem hiding this comment.
Same with this one. Every 1.0 migration is after this now.
Cherry-picked from the other branch, with a few corrections (namely the
_aggregatestables are gone now)