Skip to content

Resolve #274 #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2019
Merged

Resolve #274 #277

merged 2 commits into from
Apr 17, 2019

Conversation

Vigilans
Copy link
Contributor

#274

Resource scoped settings reference:
https://github.com/Microsoft/vscode/wiki/Adopting-Multi-Root-Workspace-APIs#settings

Since the webview panel is dependent with any resources, we can pass null for any resources, just as the warning suggests.

@Vigilans Vigilans requested a review from jdneo April 16, 2019 13:27
@jdneo jdneo added this to the 0.13.4 milestone Apr 17, 2019
@jdneo jdneo merged commit b90354e into master Apr 17, 2019
@jdneo jdneo deleted the vigilans/resource-scoped-settings branch April 17, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Vigilans @jdneo