Skip to content

Can hide the status bar #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2019
Merged

Can hide the status bar #230

merged 3 commits into from
Mar 22, 2019

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Mar 22, 2019

Resolve #156

leetcode

@jdneo jdneo added this to the 0.13.2 milestone Mar 22, 2019
@jdneo jdneo requested review from poppinlp and Vigilans March 22, 2019 10:58
Vigilans
Vigilans previously approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@Vigilans Vigilans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested without problem in my Windows and Linux machine (but with some latency to show and hide after swiching the checkbox, maybe oneday we should deal with the performance problem?).

@jdneo
Copy link
Member Author

jdneo commented Mar 22, 2019

@Vigilans Maybe instead of disposing the status bar item, I should hide it to improve the performance. I'll update the PR later

Vigilans
Vigilans approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@Vigilans Vigilans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested agian, lgtm~

@jdneo jdneo merged commit d12faba into master Mar 22, 2019
@jdneo jdneo deleted the cs/statusbar branch March 22, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poppinlp poppinlp Awaiting requested review from poppinlp

1 more reviewer

@Vigilans Vigilans Vigilans approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jdneo @Vigilans