-
Notifications
You must be signed in to change notification settings - Fork 2
refactor(kernels::grisubal): clean-up module code #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 75.29% 81.89% +6.59%
==========================================
Files 41 48 +7
Lines 6376 6853 +477
==========================================
+ Hits 4801 5612 +811
+ Misses 1575 1241 -334 ☔ View full report in Codecov by Sentry. |
cedricchevalier19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not convinced by putting the functions into step"I" files.
I think keeping a comment in the file and mod.rs that it is used in step "I" is more useful. And, you can name the files according to their contents.
|
I renamed all module files to describe the step & added comments in the |
cedricchevalier19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kernelmodule toroutines, split its original content into fileroutinesmodulegridmodule, move its content tomodel#[cfg(feature = "profiling")]attributesbuild_meshfunction to call directly step functions in the maingrisubalfunctionI will update the doc of the algorithm in a separate PR since I intend to change more things in the doc