Skip to content

Conversation

@imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Oct 31, 2024

  • rename the kernel module to routines, split its original content into file
  • turn step 1.5 into step2, offset all subsequent steps
  • add pre-processing routines to the routines module
  • delete the grid module, move its content to model
  • clean the timers implementation to hide the #[cfg(feature = "profiling")] attributes
  • remove the build_mesh function to call directly step functions in the main grisubal function

I will update the doc of the algorithm in a separate PR since I intend to change more things in the doc

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 46.39640% with 238 lines in your changes missing coverage. Please review.

Project coverage is 81.89%. Comparing base (fdb2ed9) to head (3f7228c).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...mb-kernels/src/grisubal/routines/pre_processing.rs 0.00% 162 Missing ⚠️
honeycomb-kernels/src/grisubal/mod.rs 0.00% 66 Missing ⚠️
...kernels/src/grisubal/routines/compute_new_edges.rs 84.78% 7 Missing ⚠️
...ls/src/grisubal/routines/process_intersecs_data.rs 97.22% 2 Missing ⚠️
...-kernels/src/grisubal/routines/insert_new_edges.rs 98.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   75.29%   81.89%   +6.59%     
==========================================
  Files          41       48       +7     
  Lines        6376     6853     +477     
==========================================
+ Hits         4801     5612     +811     
+ Misses       1575     1241     -334     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99 imrn99 marked this pull request as ready for review October 31, 2024 13:33
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not convinced by putting the functions into step"I" files.

I think keeping a comment in the file and mod.rs that it is used in step "I" is more useful. And, you can name the files according to their contents.

@imrn99
Copy link
Collaborator Author

imrn99 commented Nov 8, 2024

I renamed all module files to describe the step & added comments in the routines module for order.

Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imrn99 imrn99 merged commit f844145 into master Nov 11, 2024
13 checks passed
@imrn99 imrn99 deleted the split-grisubal-kernel-file branch November 11, 2024 08:36
@imrn99 imrn99 mentioned this pull request Nov 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants