Skip to content

Conversation

@imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Oct 17, 2024

  • add ParUnknownAttributeStorage, with update method sigs
  • add ParAttributeStorage, with update method sigs
  • implement these for a new struct, PAttrSparseVec

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 93.45238% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.03%. Comparing base (ab03601) to head (65c688c).

Files with missing lines Patch % Lines
honeycomb-core/src/attributes/collections.rs 90.27% 7 Missing ⚠️
honeycomb-core/src/attributes/traits.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   81.67%   82.03%   +0.35%     
==========================================
  Files          38       38              
  Lines        5342     5510     +168     
==========================================
+ Hits         4363     4520     +157     
- Misses        979      990      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99 imrn99 marked this pull request as ready for review October 17, 2024 08:42
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test the usefulness of the lock?

Can you comment on why you chose this Vec<RwLock<>> solution.
A RwLock<Vec<>> solution is also possible, can you comment on the differences?

@imrn99 imrn99 mentioned this pull request Oct 17, 2024
5 tasks
@imrn99
Copy link
Collaborator Author

imrn99 commented Oct 17, 2024

Can you test the usefulness of the lock?

I'm not sure if I can test it easily, but I can demonstrate its usefulness

Can you comment on why you chose this Vec<RwLock<>> solution. A RwLock<Vec<>> solution is also possible, can you comment on the differences?

Given the conversation in #199, I'll close this PR and use the same approach here (change the original struct). I'll do everything in #201, with a dedicated comment per change in the PR

@imrn99 imrn99 closed this Oct 17, 2024
@imrn99 imrn99 deleted the par-sparsevec branch October 25, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants