-
Notifications
You must be signed in to change notification settings - Fork 238
add hyperledger_fabric_flutter_labs.md . #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add hyperledger_fabric_flutter_labs.md . #343
Conversation
e355531 to
5c7cf42
Compare
5c7cf42 to
9aa937d
Compare
| Filed: ../hyperledger/fabric_client_flutter.md . | ||
|
|
||
| Hyperledger Labs homepage: | ||
| https://lf-decentralized-trust-labs.github.io/labs/hyperledger/fabric_client_flutter.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4 This link doesn't work for me. Do you happen to have a more up to date one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petermetz this is an unarchived link i did move from pr #345 . yes . the archived one is here : https://lf-decentralized-trust-labs.github.io/labs/archived/fabric-client-flutter.html .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intent to unarchive the previous lab or create a new one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i ' ve updated the latest links to include the lab ' s rfc and external
info for this lab . again , sorry for the inconvenience .
| Extend original fabric_client_flutter lab filed within Hyperledger Labs | ||
| . | ||
|
|
||
| Filed: ../hyperledger/fabric_client_flutter.md . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Please consider adding a link in markdown format to reference a file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i ' ve added links in markdown format to reference internal uris , while
external uris are kept in raw format to be transparency .
| fabric-server-node ( ../archived/fabric-server-node.md ) . | ||
|
|
||
| The lab introduces a playground for high-level gateway APIs for | ||
| Hyperledger Fabric version 2.4 or later on Flutter and Dart platforms . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has the project team considered extending previous lab to support newer versions of Fabric? I'm trying to understand the reason for a new project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes . the reason for a new lab can be seen on the section # rationale
and alternatives (
https://github.com/hyperledger/fabric-rfcs/pull/67/files#diff-9a02df37701ce2c2cc26070f36b7a88b25c1bfe4a6c8292f76045ec32297c75cR101-R117
) of the rfc of this lab .
|
|
||
| # Pre-existing repository | ||
|
|
||
| https://github.com/ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4/hyperledger_fabric_flutter_labs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4 On this link it says that the repository is empty. Is that really the current state or is there some source code that I could look at to better understand the scope?
In general the idea for the lab sounds great to me, I'm just wanting to make sure I do my due diligence in understanding the context before I formulate an opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petermetz the repo is empty at this point of time . i ' ve committed
some code to a previous one (
https://github.com/ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4/fabric_client_flutter
) locally to migrate some code and fix some issues but yet to push those
.
to better understand the scope of this lab , you may take a further look
at the lab ' s rfc ( currently it is at
https://github.com/hyperledger/fabric-rfcs/pull/67/files , due to the
absence of the labs rfc repo ) .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4 LGTM with comments:
- If you could update all the links to ones that are the working ones that would help with other people reading the proposal which is overall helpful not just for the TAC members, but also potential future contributors who could be interested in contributing to the lab and are trying to figure out where it came from.
Other than this - and the other pending questions from others - it looks good to me overall.
45f46e2 to
6239156
Compare
|
@petermetz i ' ve updated and included up - to - date links that are looking for if there are comments from other ppl . |
experimental playground for hyperledger fabric on flutter and dart platforms . add relevent links to the labs proposal . fix minors . link to a blog post for a previous study on flutter and dart platforms . Signed-off-by: ZHANG, HENGMING <22887031+ghpZ54K8ZRwU62zGVSePPs97yAv9swuAY0mVDR4@users.noreply.github.com>
6239156 to
be36593
Compare
experimental playground for hyperledger fabric on flutter and dart
platforms .