Feature: more KeyValueGroupedDataset wrapper functions #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p including some helper functions for GroupState. added tests
Contributor
|
Please, fix tests and I'll merge it! Thank you for contribution! |
asm0dey
reviewed
Apr 26, 2021
|
|
||
| mappedWithState.count() shouldBe 2 | ||
|
|
||
| val flatMappedWithState = groupedDataset.mapGroupsWithState { key, values, state: GroupState<Int> -> |
Contributor
There was a problem hiding this comment.
Shouldn't these be moved to separate tests?
Contributor
|
Looks like they're conflicted again… |
asm0dey
pushed a commit
that referenced
this pull request
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the last missing function wrappers for
KeyValueGroupedDatasetandcogroup()(all those shown as Java-specific) including some helper functions forGroupStatelikegetOrNull()and delegation options for state.Tests are included!