Deprecating DataFrame.read("", delimiter =)
#902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
force-pushed
the
deprecating-read-no-csv
branch
from
ac2248f to
82d94db
Compare
…avor of `readCSV`.
Jolanrensen
force-pushed
the
deprecating-read-no-csv
branch
from
82d94db to
b4ba01b
Compare
zaleslaw
reviewed
Oct 4, 2024
| @Test | ||
| fun example() { | ||
| val df = DataFrame.read("../data/titanic.csv", delimiter = ';').take(5) | ||
| val df = DataFrame.readCSV("../data/titanic.csv", delimiter = ';').take(5) |
There was a problem hiding this comment.
Do we need to replace onlhy this call? Did we have something in the docs folder?
There was a problem hiding this comment.
in theory "no" because all our docs are generated from runnable code, but I'll check anyway :)
There was a problem hiding this comment.
ha, there was one! Thanks :D
zaleslaw
approved these changes
Oct 4, 2024
|
Generated sources will be updated after merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #507
First tiny piece of #827.
All our
DataFrame.read()overloads exist in guess.kt and go over all available formats based on the file or url given to the function.DataFrame.read(..., delimiter =)can be replaced by the already existingDataFrame.readCSV(..., delimiter =)function family. This deprecates the old function with a WARNING in favor ofreadCSV.