Update of the documentation for the 0.12.1 release #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the gradleReference documentation by adding a section on how to generate schema for existing SQL tables. This includes JDBC connection establishment and usage limitations and support for particular databases.
… is a duplication of the information
Added a new document providing a step-by-step guide on importing SQL metadata as a schema in Gradle project. In addition, minor documentation enhancements were made across multiple files to ensure clarity and precision. An unnecessary OpenAPI schemas section was removed from the schemasGradle.md file due to duplication.
koperagen
reviewed
Jan 11, 2024
koperagen
reviewed
Jan 11, 2024
koperagen
reviewed
Jan 11, 2024
koperagen
reviewed
Jan 11, 2024
| ```kotlin | ||
| dataframes { | ||
| schema { | ||
| data = "jdbc:mariadb://localhost:3306/imdb" |
There was a problem hiding this comment.
Can we add a link to this database?
There was a problem hiding this comment.
I want to release example with this database and will update the links
Jolanrensen
requested changes
Jan 11, 2024
There was a problem hiding this comment.
Overall good docs :) Just many small things
I'd also like to review the other parts, added in #464 later.
…des a clearer instruction on how to import data. The change improves the language use in the guide, ensuring better understandability for users following the instructions for importing schema data from an SQL table or query.
This was referenced Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #493 Closes #546 Closes #554