Skip to content

Conversation

Jolanrensen
Copy link
Collaborator

Since all type aliases with a * are called AnySomething, it felt odd to have ColumnReference<*> be called Column. This insinuates that it is a Column object instance, which is not the case. AnyColumnReference (or a variant of that) seems more in line with the other aliases.

@Jolanrensen Jolanrensen added the invalid This issue/PR doesn't seem right label Feb 22, 2023
@Jolanrensen Jolanrensen added this to the 0.10.0 milestone Feb 22, 2023
@koperagen
Copy link
Collaborator

I'm not sure if it was intentional or indeed an inconsistency
For example, groupBy operation syntax in documentation also uses column, columns https://kotlin.github.io/dataframe/groupby.html
What do you think?

@Jolanrensen
Copy link
Collaborator Author

So does update, but those are still of type ColumnReference<C>. It's odd that groupBy has the same type of argument, just unbound (ColumnReference<*>), but it's suddenly called Column. So, I'd suggest making those ColumnReference<*> or AnyColumnReference for clarity and consistency :)

@Jolanrensen Jolanrensen merged commit 8f10093 into master Mar 7, 2023
@Jolanrensen Jolanrensen deleted the column-typealias-rename branch March 7, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This issue/PR doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants