Fix problem with big arrow #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the following bug. Steps to reproduce: 1. Execute %use dataframe 2. Calculate and render some dataframe-like table which is rendered with small arrows. It will be rendered correctly 3. Re-execute cell with %use 4. Arrows in the table now become giant Reason: When you re-execute %use command, it effectively clears all the output including CSS-s. Disappearing of styles leads to different visual problems including this one. Fix: Include CSS to the output for every dataframe-like object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the following bug.
Steps to reproduce:
Reason:
When you re-execute %use command, it effectively clears all the output including CSS-s. The disappearing of styles leads to different visual problems including this one.
Fix:
Include CSS to the output for every dataframe-like object
Possible problems:
toHTMLis a public function, and its API is broken with this commit. If it's unacceptable, consider another solution