Add API that debugger renderer can rely on to avoid breaking changes #1421
Conversation
| import org.jetbrains.kotlinx.dataframe.DataFrame; | ||
| import java.util.Collections; | ||
|
|
||
| class JsonFacadeForDebugger { |
There was a problem hiding this comment.
Any reason this is java? There's @JvmStatic() too if you need it :)
There was a problem hiding this comment.
More straightforward ABI: avoiding false assumption that parameter with a default value can be added, file name, static method
There was a problem hiding this comment.
okay, but we got a failing javadoc task because we never used to have java XD
There was a problem hiding this comment.
I think we don't add java source files from gradle
There was a problem hiding this comment.
pushed a fix disabling javadoc task. it was anyway an empty arfitact
There was a problem hiding this comment.
Then the only issue I have left is #24 but then again, when it comes around to that we can always move it to the jvm specific module
koperagen
force-pushed
the
stable-debugger-api
branch
from
0971c5a to
0cfcc12
Compare
2 participants
This is needed so adding a new argument to
toJsonWithMetadatawon't break intellij plugin. Now, even with default value, this is a breaking change from POV of debugger caller.