Add basic tests that API exposed for compiler plugin works without excluded dependencies #1397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
added
enhancement
Jolanrensen
approved these changes
Aug 19, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/convertRowCellImpl.kt
Outdated
Show resolved
Hide resolved
koperagen
force-pushed
the
delayed-static-initialization
branch
from
18d5bf6 to
15fe227
Compare
…cluded dependencies
koperagen
force-pushed
the
delayed-static-initialization
branch
from
15fe227 to
1033df2
Compare
koperagen
changed the title
df.convert { }.with { } from compiler plugin won't cause static initialization of TimeZone class
Jolanrensen
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before, calling df.convert { }.with { } from compiler plugin implementation would cause
ClassNotFoundException: kotlinx.datetime.TimeZone. As expected because we don't want to bundle kotlinx.datetime in the plugin.now with lives in its own class and can be safely called