Migrate usages of deprecated API in implementation & warning fixes #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
approved these changes
Aug 15, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/GroupByImpl.kt
Outdated
Show resolved
Hide resolved
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Analyze.kt
Show resolved
Hide resolved
koperagen
force-pushed
the
warning-fixes
branch
from
4a9c680 to
eb1b8f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to run inspections on the whole project to migrate deprecated column access API in the implementation.
Found that it's safe to replace ColumnAccessor overload when argument is either ColumnPath or actual ColumnAccessor. With FrameColumn or anything that contains actual data, migration path is not clear (see GroupByImpl for example)
Fixed some style issues / warning in the process.