Skip to content

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Jul 30, 2025

What this PR does / why we need it:

This PR aims to make CRD categories consistent.

Removes all from operator CRDs that had that set (following Gateway API upstream which doesn't include all in its types).

Adds konnect to all api/konnect types.

Which issue this PR fixes

Fixes #445

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek added this to the KO v2.0.x milestone Jul 30, 2025
@pmalek pmalek self-assigned this Jul 30, 2025
@pmalek pmalek force-pushed the consistent-categories branch from a5c686f to 62f03a7 Compare July 30, 2025 14:08
@pmalek pmalek marked this pull request as ready for review July 30, 2025 14:08
@pmalek pmalek requested a review from a team as a code owner July 30, 2025 14:08
@pmalek pmalek enabled auto-merge July 30, 2025 14:09
@pmalek pmalek force-pushed the consistent-categories branch from 62f03a7 to c4c20bc Compare July 30, 2025 14:09
randmonkey
randmonkey previously approved these changes Jul 31, 2025
@pmalek pmalek added this pull request to the merge queue Jul 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2025
@pmalek pmalek added this pull request to the merge queue Jul 31, 2025
@pmalek pmalek removed this pull request from the merge queue due to a manual request Jul 31, 2025
@pmalek pmalek force-pushed the consistent-categories branch from c4c20bc to 803c2ef Compare July 31, 2025 09:47
@pmalek pmalek requested a review from randmonkey July 31, 2025 09:48
@pmalek pmalek enabled auto-merge July 31, 2025 09:48
@pmalek
Copy link
Member Author

pmalek commented Jul 31, 2025

@randmonkey PTAL. Needed to fix changelog headers.

@pmalek pmalek force-pushed the consistent-categories branch from af4be3f to 57ef2c2 Compare July 31, 2025 15:16
@pmalek pmalek requested a review from programmer04 July 31, 2025 15:16
@pmalek pmalek added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit db43975 Jul 31, 2025
25 checks passed
@pmalek pmalek deleted the consistent-categories branch July 31, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRDs categories are inconsistent

3 participants