Skip to content

Conversation

@randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Oct 29, 2025

What this PR does / why we need it:

Use client.Watch to watch events of gateways and catch the transient state of gateway and its listeners marked as not programmed.

Which issue this PR fixes

Part of #2496

Special notes for your reviewer:
Note: In this PR I moved WatchFor to helpers package to run a more generic watch because the setupWatch in envtest cannot run on types other than our own CRD. The other types does not have our own methods so we have to use the generic method to run watches for them.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@randmonkey randmonkey force-pushed the test/watch_gateway_listener_not_programmed branch from 397fb94 to 4e711c8 Compare October 30, 2025 03:14
@randmonkey randmonkey marked this pull request as ready for review October 30, 2025 03:38
@randmonkey randmonkey requested a review from a team as a code owner October 30, 2025 03:38
@randmonkey randmonkey force-pushed the test/watch_gateway_listener_not_programmed branch from b3a1a48 to 15408b7 Compare October 30, 2025 07:20
@randmonkey randmonkey added this pull request to the merge queue Oct 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025
@randmonkey randmonkey added this pull request to the merge queue Oct 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025
@randmonkey randmonkey added this pull request to the merge queue Oct 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025
@randmonkey randmonkey added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit ab21b9e Oct 30, 2025
87 of 91 checks passed
@randmonkey randmonkey deleted the test/watch_gateway_listener_not_programmed branch October 30, 2025 09:49
programmer04 pushed a commit that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants