Skip to content

Conversation

@jD91mZM2
Copy link

Copy link
Owner

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jD91mZM2 👋

Thanks for the PR! I like the idea of no-std-compat, especially bringing alloc more into the current layering of core and std (right now alloc isn't just core + collections).

I'd like to spend a little time playing with no-std-compat to see how IDE tooling handles resolving items back to std and think about how upstream changes could be managed in direct and transitive dependencies (perhaps you could look at a nightly run of generate.py and issue a compile warning using a build.rs if the user's toolchain doesn't match the one you generated from?) Relying on rust-src to be available when compiling would be a bit problematic.

@jD91mZM2
Copy link
Author

Oof, thank god for CIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants