Skip to content

Conversation

@simi
Copy link
Contributor

@simi simi commented Jun 11, 2025

Hello!

I'm fully aware of this project is archived and it is suggested to migrate to pro version. This is just to ensure original knapsack gem latest version work also on modern Rubies. There is no need for release or any other maintenance.

@3v0k4
Copy link
Contributor

3v0k4 commented Jun 12, 2025

Hi @simi, I'd like to understand better what prompted you to open this PR.

Are you a user of this gem? Have you considered using Knapsack Pro?

We do not trigger CI builds on Github Actions. Would you be willing to share how having this change merged would help with your use-case?

@simi
Copy link
Contributor Author

simi commented Jun 12, 2025

Hello @3v0k4, I'm not Knapsack user. But I'm interested in ensuring popular gems are covered on CI with modern Rubies to get public proof those gems are compatible with them. knapsack gem still gets around ~8M downloads per month. Current master branch is code-wise same as last release (4.0.0). By approving workflow approval, we can check if gem is still compatible with Ruby 3.3 and 3.4 and by merging it will be better visible since last commit in repo will be tested against those modern Rubies.

There is no additional work needed. No need to release new gem or do any other release. It is quite similar to #120, but with newer Rubies.

@3v0k4
Copy link
Contributor

3v0k4 commented Jun 13, 2025

@simi thanks for the context. And thanks for taking care of keeping the Ruby ecosystem healthy!

Would you be willing to move racc into the gemspec together with the other dev dependencies?

I'd be happy to merge this.

- add indirect dev dependency to gemsepc
@simi
Copy link
Contributor Author

simi commented Jun 13, 2025

@3v0k4 Done. I wasn't sure where to put it, since it is not direct dependency of knapsack, this should be fixed in gherkin-ruby gem, but that is without update for 11 years and is abandoned by users also.

@3v0k4 3v0k4 merged commit 113fe95 into KnapsackPro:master Jun 13, 2025
10 checks passed
@3v0k4
Copy link
Contributor

3v0k4 commented Jun 13, 2025

@simi Thanks. Keep up the good work!

@simi simi deleted the 2025-rubies branch June 13, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants