Use default_rng() instead of GLOBAL_RNG on Julia >= 1.3
#878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Jul 5, 2023
Co-authored-by: Alex Arslan <[email protected]>
devmotion
commented
Jul 5, 2023
ararslan
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that StatsBase still uses
Random.GLOBAL_RNGas the default RNG. This PR changes it toRandom.default_rng()on Julia >= 1.3 (it was introduced in Julia 1.3) which is the new and documented API. On newer Julia versionsRandom.GLOBAL_RNGstill exists for backward compatibility but it has been observed thatRandom.GLOBAL_RNGcan lead to reduced performance.