Do not use nested dissection by default. #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 12 12
Lines 9067 9070 +3
=======================================
+ Hits 7623 7626 +3
Misses 1444 1444 ☔ View full report in Codecov by Sentry. |
Provide a named parameter `nested_dissection` to `symbolic()` to turn it on. Co-authored-by: Kristoffer Carlsson <[email protected]>
…n the Julia manual Consolidate all external packages in one place
Merged
dkarrasch
pushed a commit
that referenced
this pull request
Nov 2, 2024
* Do not use nested dissection by default. Provide a named parameter `nested_dissection` to `symbolic()` to turn it on. Co-authored-by: Kristoffer Carlsson <[email protected]> * Merge Sparse Linear Algebra docs into SparseArrays so that it shows in the Julia manual Consolidate all external packages in one place --------- Co-authored-by: Kristoffer Carlsson <[email protected]>
Merged
ViralBShah
added a commit
that referenced
this pull request
Nov 2, 2024
ViralBShah
added a commit
that referenced
this pull request
Nov 2, 2024
* Disable nested dissection (from #550) * Update CI for Julia 1.10 --------- Co-authored-by: Viral B. Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, CHOLMOD will automatically try to use nested dissection for larger matrices as discussed in #548. This can be slow and confusing for users and we do not want to use it by default.
Provide a named parameter
nested_dissectiontosymbolic()to allow the use of nested dissection.Also merge the solvers docs in the main SparseArrays docs.
Fixes #548