[libunwind] Add v1.8.1 #7959
Merged
[libunwind] Add v1.8.1 #7959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
the
julia 💜 ❤️ 💚
Member
|
https://buildkite.com/julialang/yggdrasil/builds/7797#018d136e-5e99-499b-a460-7d62227df9f9/620-2148 May need a newer gcc to compile this asm, I've seen similar assembler error before on aaarch64 |
ararslan
commented
Jan 16, 2024
Member
Author
|
@giordano, any idea what version of GCC might be needed? Some googling suggests that this |
ararslan
commented
Jan 16, 2024
Seems people building TensorFlow on Linux AArch64 hit the same inline assembly issue we're seeing here and this (plus `-flax-vector-conversion`) seems to fix it for them. This flag seems sus for libunwind but worth a try.
giordano
reviewed
Apr 18, 2024
L/LibUnwind/[email protected]/bundled/patches/libunwind-configure-static-lzma.patch
Outdated
Show resolved
Hide resolved
L/LibUnwind/[email protected]/bundled/patches/libunwind-configure-static-lzma.patch
Outdated
Show resolved
Hide resolved
Co-authored-by: Mosè Giordano <[email protected]>
Also add line breaks for long line
Member
Author
|
Ah, this is apparently a known issue: libunwind/libunwind#742 |
Should hopefully fix the inline assembly issue on AArch64?
12 seems excessive; 1.7.2 uses 5, let's try that
Member
Author
|
I've included libunwind/libunwind#748 as a patch, which fixes building on Linux AArch64. An alternative approach would have been to include a patch that reverts libunwind/libunwind#503, which is the approach that the .NET runtime took when upgrading to libunwind 1.8.0 (dotnet/runtime#96969). Evidently Xamarin has their own fix that differs from the what's implemented in the patch I've included: dotnet/android#8857. |
giordano
reviewed
Jun 13, 2024
amontoison
pushed a commit
that referenced
this pull request
Jun 22, 2024
* [libunwind] Add v1.8.0 * [libunwind 1.8.0] Amend patch * [libunwind 1.8.0] Set preferred GCC version to 6 * [libunwind 1.8.0] idk, how about gcc 12 * [libunwind] 1.8.0 -> 1.8.1 * [[email protected]] Try `-fomit-frame-pointer` on Linux AArch64 Seems people building TensorFlow on Linux AArch64 hit the same inline assembly issue we're seeing here and this (plus `-flax-vector-conversion`) seems to fix it for them. This flag seems sus for libunwind but worth a try. * Thank you, Mosè Co-authored-by: Mosè Giordano <[email protected]> * [[email protected]] rm `-fomit-frame-pointer`, prefer GCC 12 Also add line breaks for long line * [[email protected]] Include patch for PR 748 Should hopefully fix the inline assembly issue on AArch64? * [[email protected]] Try re-lowering the preferred GCC version 12 seems excessive; 1.7.2 uses 5, let's try that * Update L/LibUnwind/[email protected]/build_tarballs.jl * Revert "Update L/LibUnwind/[email protected]/build_tarballs.jl" This reverts commit c37f8f9. --------- Co-authored-by: Mosè Giordano <[email protected]> Co-authored-by: Mosè Giordano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes: libunwind/libunwind#698