[LLVM] enable Zstd and build-id for all versions

[vtjnash]

No description provided.

[giordano]

Other changes necessary are:

• bump the number in

  Yggdrasil/L/LLVM/LLVM_full@19/build_tarballs.jl

  Line 7 in 12862ef

  # Build trigger: 9

• bump the number in

  Yggdrasil/L/LLVM/LLVM_full_assert@19/build_tarballs.jl

  Line 7 in 12862ef

  # Build trigger: 10

• enabling zstd should be guarded by version checks. For example

  Yggdrasil/L/LLVM/common.jl

  Lines 208 to 209 in fb459a5

  	# Turn on ZSTD
  	CMAKE_FLAGS+=(-DLLVM_ENABLE_ZSTD=FORCE_ON)

  should be guarded by if [[ "${LLVM_MAJ_VER}" -ge "19" ]]; then and

  Yggdrasil/L/LLVM/common.jl

  Line 687 in fb459a5

  Dependency("Zstd_jll"), # for debuginfo

  and

  Yggdrasil/L/LLVM/common.jl

  Line 804 in fb459a5

  Dependency("Zstd_jll"), # for debuginfo

  should only be pushed to dependencies `if version >= v"19"

[vtjnash]

It looks like it did not rebuild those binaries, since it thinks they were in the cache. How do we drop those bad builds from the caches?

[giordano]

Yeah, as I mentioned in #11152 (comment) I think there's been a race condition with the other PR because our cache indexing doesn't capture changes in directories above the build_tarballs.jl file, but they're relevant in this case, I don't think we ever had this situation before. You can make a change like https://github.com/JuliaPackaging/Yggdrasil/compare/0a518d858d89ec06880b5c01114a552159e60b42..184adfda7640461f67125e1192f47153fd36d058, the two second PR of the two to be merged will have to resolve a merge conflict, but that's fine, I guess.