Skip to content
This repository was archived by the owner on Aug 16, 2023. It is now read-only.

Conversation

hhaensel
Copy link
Contributor

@hhaensel hhaensel commented Jun 19, 2019

  • modified tar commands for backward compatibility (e.g. busybox 1.24.1, see Busybox tar does not support requested options #162) and other compression types
  • parse_tar_list on windows returns windows paths
  • busybox tarand tar work successfully on Windows 10 if compression tools are installed (bzip)

Please comment, whether this sounds reasonable to you

…and other compression types; `parse_tar_list` on windows returns windows paths;

`busybox tar`and `tar` work successfully on Windows 10 if compression 
tools are installed (bzip)
@hhaensel
Copy link
Contributor Author

Btw, in Julia 1.1.1 busybox is no longer bundled. Is that a problem for BinaryProvider?
I received a warning

@hhaensel
Copy link
Contributor Author

Shall we merge this, as this seems to fix #162?
Just one note on the -C option of tar: although the help comment suggests the usage -C <directoryname> it also accepts -C<directoryname>. During testing I found that on windows tar can be confused by the space when using absolute filepaths. This is why I left out the space.

@staticfloat staticfloat merged commit 480eed2 into JuliaPackaging:master Jul 3, 2019
@staticfloat
Copy link
Member

Thanks @hhaensel, be sure to ping me via @staticfloat so that I know when you have things like this for me to review. Otherwise, I may not see them for a while. :)

@hhaensel hhaensel deleted the hh/normpath branch July 3, 2019 06:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants