This repository was archived by the owner on Aug 16, 2023. It is now read-only.
Add :gcc5 and :gcc6 as valid GCC choices for future-proofing
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`platform_matches()` will consider `:gcc4`, `:gcc5` and `:gcc6` as all matching at this point, as we only really care about libgfortran version. The latest compatible release should be the one that gets downloaded in the event of an ambiguity.
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 60.44% 57.02% -3.42%
==========================================
Files 8 9 +1
Lines 948 1010 +62
==========================================
+ Hits 573 576 +3
- Misses 375 434 +59
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platform_matches()will consider:gcc4,:gcc5and:gcc6as allmatching at this point, as we only really care about libgfortran version.
The latest compatible release should be the one that gets downloaded
in the event of an ambiguity.