Skip to content
This repository was archived by the owner on Aug 16, 2023. It is now read-only.

Conversation

simonbyrne
Copy link
Contributor

Hopefully fix #120.

src/Products.jl Outdated
# Grab the package name as the name of the top-level directory of a package
package_name = basename(dirname(dirname(depsjl_path)))

if VERSION < v"0.7.0-"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the VERSION check necessary, since we currently require 0.7 at a minimum?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then obviously not. There are other VERSION checks (which is why I added it), maybe have FemtoCleaner do a run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, it occurs to me that this won't work for deved packages either.

@fredrikekre
Copy link
Member

You can not get the package name from the file path in general. In particular this will not work for packages that are deved.

@codecov-io
Copy link

codecov-io commented Nov 5, 2018

Codecov Report

Merging #137 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   60.46%   60.44%   -0.03%     
==========================================
  Files           8        8              
  Lines         946      948       +2     
==========================================
+ Hits          572      573       +1     
- Misses        374      375       +1
Impacted Files Coverage Δ
src/Products.jl 67.22% <33.33%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53dbc7c...ad8f70d. Read the comment docs.

@staticfloat
Copy link
Member

I'm happy to cheat and do stupid things that work here:

# Auto-detect being placed within the `~/.julia/packages/XXXXX` directory
if basename(dirname(dirname(dirname(dirname(depsjl_path))))) == "packages"
    package_name = basename(dirname(dirname(dirname(depsjl_path))))
else
    package_name = basename(dirname(dirname(depsjl_path)))
end

@staticfloat
Copy link
Member

It Works

@staticfloat staticfloat merged commit 229e2c1 into JuliaPackaging:master Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The identified package name in check_deps is wrong

5 participants