reduced precision for lanczos_opencv #635
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using Float32 for Lanczos is ~2x faster and uses ~1/2x as much memory as the current Float64.
this PR currently uses whatever precision was input as the precision the internal calculations are performed with. i could also imagine specifying the type used for internal computations in the type (e.g.
struct Lanczos4OpenCV{T} <: AbstractLanczos end) to separate it from the input.i'm also curious where there is a more clever way to cast
l4_2d_csat compile time so as not to incur runtime penalities.let me know what you think and i'll add some tests and docs.