Skip to content

Conversation

Crown421
Copy link
Collaborator

@Crown421 Crown421 commented Jan 2, 2020

This PR moves testing to GitHub actions.

The testing is now split into two parts, one workflow that tests for Julia 1.0 and 1.3 for pushes and pull requests, and one workflow for Julia nightly which in additions runs twice a month.
Additionally, there is a test that installs standalone MKL on Linux and tests the package using it.
Respective badges have been added to the Readme.

Windows testing is currently disabled, as building MKL.jl on Windows is currently broken (see JuliaLinearAlgebra/MKL.jl#24) and I don't know a good way to install standalone MKL via CLI on Windows

There appears to be a merging issue, but the jobs run successfully on my (updated) fork as seen here.

@Crown421 Crown421 requested a review from aminya January 2, 2020 22:09
Copy link
Member

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checks are passed this should be merged

@Crown421
Copy link
Collaborator Author

Crown421 commented Jan 2, 2020

After this is done, I want to add the tests for the mutations versions of the functions, and then I would declare testing 1.0 ready.

@Crown421 Crown421 merged commit ffc159c into master Jan 2, 2020
@Crown421 Crown421 deleted the GH_Actions branch February 3, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants