Skip to content

Conversation

@gdalle
Copy link
Contributor

@gdalle gdalle commented Oct 31, 2021

Hi there,
I just added a Documenter workflow with GitHub Actions to replace the old functions list in the README. @logankilpatrick I think you said you would be happy to review?
On a side note, since the Travis CI workflow hasn't been used in a year, maybe we could switch all of it to GitHub Actions? I'm no expert though, I usually copy the CI files from PkgTemplates.jl and it does the job ^^
Thanks in advance!

@gdalle
Copy link
Contributor Author

gdalle commented Oct 31, 2021

Since I wanted to test deployment on my fork, one would have to change the GitHub username and stuff like that to make it work on JuliaMath/Combinatorics.jl

@logankilpatrick
Copy link
Contributor

Yes happy to merge this, what other steps do I need to do after the merge to get this up? Just setup secrets for the repo?

@gdalle
Copy link
Contributor Author

gdalle commented Nov 1, 2021

I never had to set up secrets for GitHub Actions, at least not with the CI files I put there (which are taken straight from PkgTemplates). However you will need to activate GitHub Pages in repo settings and point it to the correct branch and folder

@logankilpatrick logankilpatrick merged commit 4f654b9 into JuliaMath:master Nov 1, 2021
@logankilpatrick
Copy link
Contributor

Working like a charm: https://juliamath.github.io/Combinatorics.jl/dev/ thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants