Propagate Log Level Override #67
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the broken test for using
with_level
on top of a compositional logger.I had hoped there was something we were doing wrong in the compositional components,
the fixing of which would make this all work elegantly.
But there is not.1
So instead this takes the brute force approach of recursively reconstructing the logging stack. (well tree)
Luckily there is only a very finite number of logging types we will ever have so we can just handle each case.
TODO:
min_enabled_level
(I don't think we can)1 I have noted before this compositional loggers feels like how logging in julia should work, but it does not get a clean implementation, for julia 2.0 we should change Logging some how, including incorperating compositional logging into the stdlib, and removing inpure sinks.)