Adjust to AdjointFactorization #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YingboMa
reviewed
Feb 12, 2023
Co-authored-by: Yingbo Ma <[email protected]>
Member
Author
|
Shall we merge and release? It works on my PR branch. |
Member
|
Why do we need to release this change? Only tests are updated. |
Member
Author
To "verify publicly" that my Julia PR doesn't break the ecosystem via a nanosoldier pkgeval run. There is also another commit after the last release, so it wouldn't be tests only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares the ground for JuliaLang/julia#46874 and lets CI run smoothly before and after that PR. I suggest to bump the patch version even though this just changes a test, so that nanosoldier can see this.