Skip to content

Conversation

@KristofferC
Copy link
Member

@KristofferC KristofferC commented Nov 6, 2025

This helps handling manifest from earlier julia versions. This is kind of the locate version of the identify fallback in #56148.

Need to write a test when this happens (and verify that this fix works).

Noted in a slack #gripes comment.

this helps handling manifest from earlier julia versions
@KristofferC KristofferC added packages Package management and loading backport 1.10 Change should be backported to the 1.10 release backport 1.12 Change should be backported to release-1.12 backport 1.13 labels Nov 6, 2025
@kescobo
Copy link
Contributor

kescobo commented Nov 6, 2025

Adding context from a gripe on slack that kicked this off, when I freshly cloned https://github.com/kescobo/audiommunity.org/tree/abab70896694f6ea7563fed6c460c66d892293ea and then started julia with julia --project, entering the Pkg REPL with ] immediately triggered a bunch of precompilation and throwing errors.

I was able to start julia without --project and then to ] activate ., but the user experience of being thrown into a bunch of exceptions when activating the Pkg REPL is not ideal.

@KristofferC
Copy link
Member Author

KristofferC commented Nov 6, 2025

This happens when we have a manifest with what is now an stdlib but in the julia version of that manifest it was not (OpenSSL).

@KristofferC KristofferC changed the title allow finding stdlibs that are not in the manifest as a fallback allow finding stdlibs that are normal packages in the manifest but are now stdlibs Nov 6, 2025
@KristofferC
Copy link
Member Author

Added test, also corrected the test from #56148 (cc @IanButterworth)

Copy link
Member

@IanButterworth IanButterworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. So the test erroneously passed before because the projecf path was set incorrectly?

@KristofferC
Copy link
Member Author

So the test erroneously passed before because the projecf path was set incorrectly?

No, that test actually worked (but it failed to test the thing it was trying to test). The change here is not fixing that, it is fixing another failure mode where we have a manifest with a package that was not an stdlib in an earlier Julia versions but now is an stdlib (e.g. OpenSSL_jl).

@KristofferC KristofferC mentioned this pull request Nov 7, 2025
35 tasks
@fingolfin fingolfin added the merge me PR is reviewed. Merge when all tests are passing label Nov 10, 2025
@KristofferC
Copy link
Member Author

I tried this on the example in #60061 (comment) and it seems to work fine.

@fingolfin fingolfin merged commit 6fddac8 into master Nov 10, 2025
8 checks passed
@fingolfin fingolfin deleted the kc/locate_stdlib branch November 10, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.10 Change should be backported to the 1.10 release backport 1.12 Change should be backported to release-1.12 backport 1.13 merge me PR is reviewed. Merge when all tests are passing packages Package management and loading

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants