-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
allow finding stdlibs that are normal packages in the manifest but are now stdlibs #60061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this helps handling manifest from earlier julia versions
|
Adding context from a gripe on slack that kicked this off, when I freshly cloned https://github.com/kescobo/audiommunity.org/tree/abab70896694f6ea7563fed6c460c66d892293ea and then started julia with I was able to start julia without |
|
This happens when we have a manifest with what is now an stdlib but in the julia version of that manifest it was not (OpenSSL). |
|
Added test, also corrected the test from #56148 (cc @IanButterworth) |
IanButterworth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. So the test erroneously passed before because the projecf path was set incorrectly?
No, that test actually worked (but it failed to test the thing it was trying to test). The change here is not fixing that, it is fixing another failure mode where we have a manifest with a package that was not an stdlib in an earlier Julia versions but now is an stdlib (e.g. OpenSSL_jl). |
|
I tried this on the example in #60061 (comment) and it seems to work fine. |
This helps handling manifest from earlier julia versions. This is kind of the
locateversion of theidentifyfallback in #56148.Need to write a test when this happens (and verify that this fix works).
Noted in a slack #gripes comment.