Skip to content

fix string completion with cursor in the middle of text #60055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

fix string completion with cursor in the middle of text #60055

merged 1 commit into from
Nov 6, 2025

Conversation

@KristofferC
Copy link
Member

@KristofferC KristofferC commented Nov 5, 2025

Fixes #60050

We can see how this is symmetric with how e.g. keys in dicts are handled:

julia/stdlib/REPL/src/REPLCompletions.jl

Line 1025 in d665f89

s = string[intersect(key, 1:pos)]

I think this got introdced in #57767

Tests written by Claude Code 🤖

@KristofferC KristofferC requested a review from xal-0 November 5, 2025 21:18
@KristofferC KristofferC added backport 1.12 Change should be backported to release-1.12 backport 1.13 labels Nov 5, 2025
@KristofferC KristofferC mentioned this pull request Nov 5, 2025
Closed
@KristofferC KristofferC added REPL Julia's REPL (Read Eval Print Loop) bugfix This change fixes an existing bug labels Nov 5, 2025
@KristofferC KristofferC merged commit 1cc404e into master Nov 6, 2025
10 of 12 checks passed
@KristofferC KristofferC deleted the kc/string_complete branch November 6, 2025 13:23
@topolarity
Copy link
Member

topolarity commented Nov 6, 2025

This seems to be causing x86_64-w64-mingw32 and i686-w64-mingw32 tests to fail: https://buildkite.com/julialang/julia-master/builds/51916#019a55e3-d265-4801-a22e-603447dc7261/1055-1777

@KristofferC
Copy link
Member Author

KristofferC commented Nov 6, 2025

Sorry about that, looks like the path separators are problematic

C:\\Users\\julia\\AppData\\Local\\Temp\\jl_YoprOt/foo_dir/
C:\\Users\\julia\\AppData\\Local\\Temp\\jl_YoprOt\\foo_dir\\

@KristofferC
Copy link
Member Author

KristofferC commented Nov 6, 2025

I won't have time to fix and test this properly this evening so I'll revert and reland it tomorrow.

KristofferC added a commit that referenced this pull request Nov 6, 2025
@KristofferC
Revert "fix string completion with cursor in the middle of text (#60055…
b57589a 
…)"

This reverts commit 1cc404e.
@KristofferC KristofferC mentioned this pull request Nov 6, 2025
Merged
DilumAluthge pushed a commit that referenced this pull request Nov 7, 2025
@KristofferC
Revert "fix string completion with cursor in the middle of text" (#60068
bac33d5 
)

Reverts #60055
@DilumAluthge DilumAluthge added the reverted This PR has since been reverted label Nov 7, 2025
KristofferC added a commit that referenced this pull request Nov 7, 2025
@KristofferC
fix string completion with cursor in the middle of text (#60055)
fe7f9d4 
(cherry picked from commit 1cc404e)
@KristofferC KristofferC mentioned this pull request Nov 7, 2025
Merged
35 tasks
KristofferC added a commit that referenced this pull request Nov 10, 2025
@KristofferC
fix string completion with cursor in the middle of text (#60055)
afcf015 
(cherry picked from commit 1cc404e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash approved these changes

@xal-0 xal-0 Awaiting requested review from xal-0

Assignees

No one assigned

Labels

backport 1.12 Change should be backported to release-1.12 backport 1.13 bugfix This change fixes an existing bug REPL Julia's REPL (Read Eval Print Loop) reverted This PR has since been reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression in REPL file path completion in 1.12

5 participants

@KristofferC @topolarity @vtjnash @DilumAluthge