fix: TOML parsing of fractional seconds #59999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
added
backport 1.10
- fix a bug in which parsing the digits after the decimal point of a (date-)time like "00:00:00.12" were interpreted as "12 milliseconds" instead of "0.12 seconds". Now, the fractional part is correctly parsed as a fraction of a second, then correctly converted to milliseconds. As before, only the first three digits after the decimal point are considered.
haakon-e
force-pushed
the
he/fix-toml-parsing-of-fractional
branch
from
5d96e17 to
938b37d
Compare
Contributor
Author
|
This PR works for me locally. I haven't contributed a bugfix to julia before, so I would appreciate any guidance for additional components needed to merge this (e.g. update NEWS file?) |
Member
|
There is typically no need for NEWS entry for bugfixes like this. Thanks for the contribution! |
KristofferC
pushed a commit
that referenced
this pull request
Nov 5, 2025
fix a bug in which parsing the digits after the decimal point of a (date-)time like "00:00:00.12" were interpreted as "12 milliseconds" instead of "0.12 seconds". Now, the fractional part is correctly parsed as a fraction of a second, then correctly converted to milliseconds. As before, only the first three digits after the decimal point are considered. Closes #59997 --- With a local build of this PR, the example from the above issue now evaluates to: ```julia julia> t2 = TOML.parse("""time = 00:00:00.2""") Dict{String, Any} with 1 entry: "time" => 00:00:00.2 julia> millisecond(t2["time"]) 200 ``` (cherry picked from commit 906d64e)
17 tasks
KristofferC
pushed a commit
that referenced
this pull request
Nov 7, 2025
fix a bug in which parsing the digits after the decimal point of a (date-)time like "00:00:00.12" were interpreted as "12 milliseconds" instead of "0.12 seconds". Now, the fractional part is correctly parsed as a fraction of a second, then correctly converted to milliseconds. As before, only the first three digits after the decimal point are considered. Closes #59997 --- With a local build of this PR, the example from the above issue now evaluates to: ```julia julia> t2 = TOML.parse("""time = 00:00:00.2""") Dict{String, Any} with 1 entry: "time" => 00:00:00.2 julia> millisecond(t2["time"]) 200 ``` (cherry picked from commit 906d64e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a bug in which parsing the digits after the decimal point of a (date-)time like "00:00:00.12" were interpreted as "12 milliseconds" instead of "0.12 seconds". Now, the fractional part is correctly parsed as a fraction of a second, then correctly converted to milliseconds. As before, only the first three digits after the decimal point are considered.
Closes #59997
With a local build of this PR, the example from the above issue now evaluates to: