reflection: Label "dynamic invoke" in code_typed
#58411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the optimizer leaves a dispatch resolved, but the code was not available / provided at compile-time. This requires running the JIT to execute, since it means we left an edge of the call graph un-resolved. This change highlights this in `code_typed` to match, e.g., how we handle "dynamic" built-ins.
topolarity
force-pushed
the
ct/dynamic-invoke
branch
from
61a4958 to
fbb61b0
Compare
aviatesk
reviewed
May 15, 2025
topolarity
added
merge me
KristofferC
pushed a commit
that referenced
this pull request
May 20, 2025
(cherry picked from commit 43ead47)
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this when inference was trying to compile a signature and then exhausted its recursion heuristic and refused (correctly) to cache the CI, meaning that this codegen edge was not fully resolved (despite being left as an invoke).
A "dynamic invoke" like this can also be an intended result if inference knows what method you're dispatching to (e.g.
convert(::Foo, ::Integer)) but the optimizer decides that it wants to specialize this call more aggressively (e.g.convert(::Foo, ::UInt8),convert(::Foo, ::Int8),convert(::Foo, ::UInt16), etc.) when generating machine code.I think the compiler currently does that rarely in practice (it prefers to not add the edge if it cannot enumerate the code on the other side), but either way, we should highlight this in
code_typed