Fix missing CodeInstance owner lookup in _jl_invoke #58072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_jl_invoke` has a manually inlined version of `jl_method_compiled` that was missing the `->owner` check. I don't think there's any strong reason to duplicate this code path, so unify them and make sure the `->owner` path is there. This fixes an issue where calling `CompilerDevTools`'s `with_new_compiler` would cause the creation of CodeInstances that would then be dispatched to outside the `with_new_compiler` context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_jl_invokehas a manually inlined version ofjl_method_compiledthat was missing the->ownercheck. I don't think there's any strong reason to duplicate this code path, so unify them and make sure the->ownerpath is there. This fixes an issue where callingCompilerDevTools'swith_new_compilerwould cause the creation of CodeInstances that would then be dispatched to outside thewith_new_compilercontext.