trimming: Avoid using indirectly-loaded packages
#57589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just because a package is loaded doesn't mean that we have top-level `using` rights, so we need to pull the Module straight out of the loaded modules array in order to do these hacks.
nsajko
added
the
trimming
JeffBezanson
approved these changes
Mar 1, 2025
vchuravy
reviewed
Mar 7, 2025
| # Additional method patches depending on whether user code loads certain stdlibs | ||
| let loaded = Base.loaded_modules_array() | ||
| function find_loaded_module(name) | ||
| idx = findfirst((m) -> Symbol(m) === name, loaded) |
Member
There was a problem hiding this comment.
We should probably use UUID (or name+UUID) here.
oscardssmith
pushed a commit
that referenced
this pull request
Mar 8, 2025
As recommended in #57589 (comment)
KristofferC
pushed a commit
that referenced
this pull request
Mar 21, 2025
Although a package is loaded, we may not have top-level `using` rights. Instead, we need to pull the Module straight out of the loaded modules array in order to do these hacks. (cherry picked from commit 1cead2b)
KristofferC
pushed a commit
that referenced
this pull request
Mar 21, 2025
As recommended in #57589 (comment) (cherry picked from commit eba2a33)
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although a package is loaded, we may not have top-level
usingrights.Instead, we need to pull the Module straight out of the loaded modules array in order to do these hacks.