Skip to content

REPLCompletions: allow completions for import Mod.xxx #54691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024
Merged

REPLCompletions: allow completions for import Mod.xxx #54691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions stdlib/REPL/src/REPLCompletions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,6 +1132,10 @@ function complete_identifiers!(suggestions::Vector{Completion},
end
isexpr(ex, :incomplete) && (ex = nothing)
elseif isexpr(ex, (:using, :import))
if isexpr(ex, :import)
# allow completion for `import Mod.name` (where `name` is not a module)
complete_modules_only = false
end
arglast = ex.args[end] # focus on completion to the last argument
if isexpr(arglast, :.)
# We come here for cases like:
Expand Down
15 changes: 15 additions & 0 deletions stdlib/REPL/test/replcompletions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2308,3 +2308,18 @@ let s = "TestImplicitUsing.@asse"
@test res
@test "@assert" in c
end

# JuliaLang/julia#23374: completion for `import Mod.name`
module Issue23374
global v23374 = nothing
end
let s = "import .Issue23374.v"
c, r, res = test_complete_context(s)
@test res
@test "v23374" in c
end
let s = "using .Issue23374.v"
c, r, res = test_complete_context(s)
@test res
@test isempty(c)
end