Deps: after configuring CMake project, use cmake --build, not make
#54538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, there's really not much reason to use `make` directly in that case, `cmake --build` is guaranteed to do the right thing. Secondly, the CMake's default generator can be different from `Unix Makefiles`, it might be `Ninja`, regardless of "LLVM"-specific `CMAKE_GENERATOR` override. It's best to just *consistently* rely on `cmake --build`.
fingolfin
approved these changes
May 25, 2024
Contributor
Author
|
@fingolfin thank you! |
DilumAluthge
pushed a commit
that referenced
this pull request
Jun 3, 2024
#54538) First, there's really not much reason to use `make` directly in that case, `cmake --build` is guaranteed to do the right thing. Secondly, the CMake's default generator can be different from `Unix Makefiles`, it might be `Ninja`, regardless of "LLVM"-specific `CMAKE_GENERATOR` override. It's best to just *consistently* rely on `cmake --build`.
This was referenced Jul 9, 2024
ararslan
added a commit
that referenced
this pull request
Jul 10, 2024
A couple of the changes made in #54538 were incorrect. In particular: - libunwind (non-LLVM) does not use CMake, so the `$(CMAKE) --build` is simply reverted here back to `$(MAKE) -C`. - zlib does use CMake but regular Make flags were being passed to its `$(CMAKE) --build`. Those can just be dropped since it's already getting the proper CMake flags.
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
JuliaLang#54538) First, there's really not much reason to use `make` directly in that case, `cmake --build` is guaranteed to do the right thing. Secondly, the CMake's default generator can be different from `Unix Makefiles`, it might be `Ninja`, regardless of "LLVM"-specific `CMAKE_GENERATOR` override. It's best to just *consistently* rely on `cmake --build`.
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Jul 28, 2024
…ot `make` (JuliaLang#54538)" This reverts commit 8fd5aeb.
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Aug 17, 2024
LebedevRI
added a commit
to LebedevRI/julia
that referenced
this pull request
Apr 30, 2025
While JuliaLang#54538 previously attempted to properly handle this the other way, by calling `cmake --build`, but that was reverted with some weird issues on CI, see JuliaLang#55284 Maybe those issues have gone away by themselves, maybe not. But let's at least make things work first.
LebedevRI
added a commit
to LebedevRI/julia
that referenced
this pull request
May 1, 2025
This was previously attempted in JuliaLang#54538, but reverted in JuliaLang#55285 because of JuliaLang#55284: ``` After 8fd5aeb, building LLVM on CI as part of JuliaCI/julia-buildkite#345 just seems to hang until a cancellation signal at which points it starts building again. See https://buildkite.com/julialang/julia-buildkite/builds/1608#0190f950-0eb6-4fe3-938b-af69d186c40a for an example log with -d passed to make. ``` Bad iteraction with Make jobserver is suspected, Maybe the issue has since fixed itself? See JuliaLang#58284
LebedevRI
added a commit
to LebedevRI/julia
that referenced
this pull request
May 2, 2025
This was previously attempted in JuliaLang#54538, but reverted in JuliaLang#55285 because of JuliaLang#55284: ``` After 8fd5aeb, building LLVM on CI as part of JuliaCI/julia-buildkite#345 just seems to hang until a cancellation signal at which points it starts building again. See https://buildkite.com/julialang/julia-buildkite/builds/1608#0190f950-0eb6-4fe3-938b-af69d186c40a for an example log with -d passed to make. ``` Bad iteraction with Make jobserver is suspected, Maybe the issue has since fixed itself? See JuliaLang#58284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, there's really not much reason to use
makedirectly in that case,cmake --buildis guaranteed to do the right thing.Secondly, the CMake's default generator can be different from
Unix Makefiles, it might beNinja,regardless of "LLVM"-specific
CMAKE_GENERATORoverride.It's best to just consistently rely on
cmake --build.