Skip to content

Artifacts: Change Dict{AbstractPlatform} to Dict{Platform} to reduce Pkg invalidations #54073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 19, 2024
Merged

Artifacts: Change Dict{AbstractPlatform} to Dict{Platform} to reduce Pkg invalidations #54073

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9ded1a6
Stop using Dict{AbstractPlatform,Dict{String,Any}} in Artifacts
mkitti Apr 14, 2024
bb65a99
Add method for artifact_meta(::AbstractString, ::Dict, ::AbstractStri…
mkitti Apr 14, 2024
77ce773
Add artifact_meta(::String, ::String, ::Platform)
mkitti Apr 14, 2024
0ae539d
Fix references to artifact_toml rather than artifacts_toml
mkitti Apr 15, 2024
6be665a
Make compatible with BinaryBuilderBase.AnyPlatform
mkitti Apr 16, 2024
843b80b
Revert "Make compatible with BinaryBuilderBase.AnyPlatform"
mkitti Apr 17, 2024
881a3e6
Do not error when showing an unexpected platform name
mkitti Apr 17, 2024
097c0c9
Delete extra newline
mkitti Apr 18, 2024
7656e4c
Minimize diff to master, do create new methods, just convert
mkitti Apr 18, 2024
fe94768
Remove convert(Platform, platform)
mkitti Jun 18, 2024
3c2198b
Remove binaryplatforms.jl changes, implementing convert(::Type{Platfo…
mkitti Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions stdlib/Artifacts/src/Artifacts.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ that would be convenient to place within an immutable, life-cycled datastore.
module Artifacts

import Base: get, SHA1
using Base.BinaryPlatforms, Base.TOML
using Base.BinaryPlatforms: AbstractPlatform, Platform, HostPlatform
using Base.BinaryPlatforms: tags, triplet, select_platform
using Base.TOML: TOML

export artifact_exists, artifact_path, artifact_meta, artifact_hash,
select_downloadable_artifacts, find_artifacts_toml, @artifact_str
Expand Down Expand Up @@ -400,7 +402,7 @@ function artifact_meta(name::String, artifact_dict::Dict, artifacts_toml::String

# If it's an array, find the entry that best matches our current platform
if isa(meta, Vector)
dl_dict = Dict{AbstractPlatform,Dict{String,Any}}()
dl_dict = Dict{Platform,Dict{String,Any}}()
for x in meta
x = x::Dict{String, Any}
dl_dict[unpack_platform(x, name, artifacts_toml)] = x
Expand Down