Revert "small changes to make Base more statically compileable" #53808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
reviewed
Mar 22, 2024
| if ccall(:ios_file, Ptr{Cvoid}, | ||
| (Ptr{UInt8}, Cstring, Cint, Cint, Cint, Cint), | ||
| s.ios, fname, flags.read, flags.write, flags.create, flags.truncate) == C_NULL | ||
| systemerror("opening file \"$fname\"") |
Member
There was a problem hiding this comment.
Looks like this change is the actual issue here. Just replace this with $(repr(fname)) as it was before?
This reverts commit e0bb95a.
IanButterworth
force-pushed
the
revert-53778-jb/morecompileable
branch
from
9e4918a to
4154693
Compare
Member
Author
|
#53813 is stalling so I'll merge this to get CI green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #53778 which appears to have introduced a windows failure
See #53778 (comment)