Skip to content

Conversation

@oxinabox
Copy link
Contributor

@oxinabox oxinabox commented Mar 6, 2024

Follow up to #53602 (comment)
all the related need_to_handle_undef_sparam should now pass if this is right

@oscardssmith oscardssmith added the bugfix This change fixes an existing bug label Mar 8, 2024
@oscardssmith
Copy link
Member

is this ready to merge?

@oxinabox
Copy link
Contributor Author

It seems the CI failures are legit

@martinholters
Copy link
Member

Aren't the ::Type{Missing} methods still needed? (Or a branch to deal with T==Missing to avoid calling nonmissingtype_checked on it.)
OTOH, the ::Type{Any} might not be needed anymore to prevent a stack overflow, as the nonmissingtype_checked will throw in the ::Type{>:Missing} method. (But the more specific error might still be worth it.)

@adienes adienes added forget me not missing data Base.missing and related functionality labels Sep 16, 2025
@DilumAluthge
Copy link
Member

It seems the CI failures are legit

Yes, it looks like the CI failures are related to the changes in this PR.

@oxinabox Are you still interested in working on this? If not, @oscardssmith would you be interested in taking over this PR?

I'm asking because I see the forget me not label here.

@oxinabox
Copy link
Contributor Author

this is still a change we should have.
I would appreciate it if @oscardssmith took it over

@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing and removed status: waiting for PR author forget me not labels Oct 2, 2025
@DilumAluthge DilumAluthge changed the title change how we handle unions of missings and other types in unitary functions Change how we handle unions of missings and other types in unitary functions Oct 3, 2025
@DilumAluthge
Copy link
Member

CI failures seem related to the contents of this PR.

@oscardssmith can I assign this PR for you to take over as the new PR "author"? And to take a look at the failing tests?

@DilumAluthge DilumAluthge added status: waiting for PR author and removed merge me PR is reviewed. Merge when all tests are passing labels Oct 3, 2025
@oscardssmith
Copy link
Member

will investigate.

@DilumAluthge DilumAluthge added the failing CI is failing. Needs attention. No need to re-run CI. label Oct 3, 2025
@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing and removed status: waiting for PR author failing CI is failing. Needs attention. No need to re-run CI. labels Oct 3, 2025
@DilumAluthge
Copy link
Member

Some more test failures:

Error in testset missing:
Test Failed at /cache/build/tester-amdci5-12/julialang/julia-master/julia-fc50b93d31/share/julia/test/missing.jl:233
  Expression: zero(Missing) === missing
   Evaluated: Missing === missing
Error in testset missing:
Test Failed at /cache/build/tester-amdci5-12/julialang/julia-master/julia-fc50b93d31/share/julia/test/missing.jl:234
  Expression: one(Missing) === missing
   Evaluated: Missing === missing
Error in testset missing:
Test Failed at /cache/build/tester-amdci5-12/julialang/julia-master/julia-fc50b93d31/share/julia/test/missing.jl:235
  Expression: oneunit(Missing) === missing
   Evaluated: Missing === missing

@DilumAluthge DilumAluthge added failing CI is failing. Needs attention. No need to re-run CI. and removed merge me PR is reviewed. Merge when all tests are passing labels Oct 3, 2025
DilumAluthge and others added 2 commits October 3, 2025 16:15
whoops, I can pretend to know the difference between a type an value
@oscardssmith oscardssmith assigned vtjnash and unassigned oscardssmith Oct 4, 2025
@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing and removed failing CI is failing. Needs attention. No need to re-run CI. labels Oct 4, 2025
@vtjnash
Copy link
Member

vtjnash commented Oct 4, 2025

CI failure looks unrelated, just waiting for the Windows builders to actually get around to running

@IanButterworth IanButterworth merged commit e7b5082 into JuliaLang:master Oct 4, 2025
9 checks passed
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Oct 4, 2025
@nsajko nsajko added the error handling Handling of exceptions by Julia or the user label Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This change fixes an existing bug error handling Handling of exceptions by Julia or the user missing data Base.missing and related functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants