Skip to content

fix invalidations related to ismutable #52170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 28, 2023
Merged

fix invalidations related to ismutable #52170

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ead663
fix invalidations related to ismutable
ranocha Nov 14, 2023
3f5436c
apply suggestion from code review
ranocha Nov 15, 2023
ab6db68
Revert "apply suggestion from code review"
ranocha Nov 22, 2023
8c079b8
Merge branch 'master' into hr/ismutable
KristofferC Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion base/reflection.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,9 @@ true
!!! compat "Julia 1.5"
This function requires at least Julia 1.5.
"""
ismutable(@nospecialize(x)) = (@_total_meta; typeof(x).name.flags & 0x2 == 0x2)
ismutable(@nospecialize(x)) = (@_total_meta; (typeof(x).name::Core.TypeName).flags & 0x2 == 0x2)
# The type assertion above is required to fix some invalidations.
# See also https://github.com/JuliaLang/julia/issues/52134

"""
ismutabletype(T) -> Bool
Expand Down