inlining: allow callsite inlining with cached results #50048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
added
the
compiler:optimizer
In some rare cases with callsite inlining, we try to inline an inferred result from a local cache (`inf_result::InferenceResult`), whose source has been transformed by `transform_result_for_cache`. At present, `inf_result.src` stays to be `OptimizationState` in such cases, causing `inlining_policy` to handle the callsite inlining. This commit adjusts `transform_result_for_cache` so that it stores the transformed source in `inf_result.src`, letting the callsite inliner use it. Down the line, we might revisit this change to align it with 532125d, which isn't enabled yet.
aviatesk
force-pushed
the
avi/callsite-inlining
branch
from
5a8b7a5 to
6d162e3
Compare
Member
Author
|
@nanosoldier |
Collaborator
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. |
KristofferC
pushed a commit
that referenced
this pull request
Jun 6, 2023
In some rare cases with callsite inlining, we try to inline an inferred result from a local cache (`inf_result::InferenceResult`), whose source has been transformed by `transform_result_for_cache`. At present, `inf_result.src` stays to be `OptimizationState` in such cases, causing `inlining_policy` to handle the callsite inlining. This commit adjusts `transform_result_for_cache` so that it stores the transformed source in `inf_result.src`, letting the callsite inliner use it. Down the line, we might revisit this change to align it with 532125d, which isn't enabled yet. (cherry picked from commit f407a4c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases with callsite inlining, we try to inline an inferred result from a local cache (
inf_result::InferenceResult), whose source has been transformed bytransform_result_for_cache. At present,inf_result.srcstays to beOptimizationStatein such cases, causinginlining_policyto handle the callsite inlining.This commit adjusts
transform_result_for_cacheso that it stores the transformed source ininf_result.src, letting the callsite inliner use it. Down the line, we might revisit this change to align it with 532125d, which isn't enabled yet.